Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(expr): add array_sort #12189

Merged
merged 3 commits into from
Sep 12, 2023
Merged

feat(expr): add array_sort #12189

merged 3 commits into from
Sep 12, 2023

Conversation

xzhseh
Copy link
Contributor

@xzhseh xzhseh commented Sep 8, 2023 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

add array_sort & related #11996

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xzhseh xzhseh self-assigned this Sep 8, 2023
@xzhseh xzhseh added the user-facing-changes Contains changes that are visible to users label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Merging #12189 (29f2bb4) into main (3c0284e) will decrease coverage by 0.01%.
The diff coverage is 11.76%.

@@            Coverage Diff             @@
##             main   #12189      +/-   ##
==========================================
- Coverage   69.78%   69.77%   -0.01%     
==========================================
  Files        1408     1409       +1     
  Lines      235754   235771      +17     
==========================================
+ Hits       164516   164520       +4     
- Misses      71238    71251      +13
Flag Coverage Δ
rust 69.77% <11.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/frontend/src/expr/pure.rs 87.69% <ø> (ø)
src/frontend/src/expr/type_inference/func.rs 81.27% <0.00%> (-0.29%) ⬇️
src/expr/src/vector_op/array_sort.rs 7.69% <7.69%> (ø)
src/frontend/src/binder/expr/function.rs 78.77% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xzhseh
Copy link
Contributor Author

xzhseh commented Sep 11, 2023

The updated version changes DefaultOrdered(ScalarRefImpl<'_>) to DefaultOrdered(DatumRef<'_>), thus keep NULLs at the very end after sorting by default 🥵.

wangrunji0408
wangrunji0408 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit f8d6b24 Sep 12, 2023
@wangrunji0408 wangrunji0408 deleted the xzhseh/feat-array-sort branch September 12, 2023 04:07
Li0k pushed a commit that referenced this pull request Sep 15, 2023
@xzhseh @Li0k
feat(expr): add array_sort (#12189)
afc1c8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangrunji0408 wangrunji0408 wangrunji0408 approved these changes

@TennyZhuang TennyZhuang Awaiting requested review from TennyZhuang

@xiangjinwu xiangjinwu Awaiting requested review from xiangjinwu

Assignees

@xzhseh xzhseh

Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xzhseh @TennyZhuang @wangrunji0408